Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 5384: Created the home page for French localization #5386

Merged
merged 15 commits into from
Oct 14, 2024
Merged

Issue 5384: Created the home page for French localization #5386

merged 15 commits into from
Oct 14, 2024

Conversation

iguitton
Copy link
Contributor

@dmathieu, @bertysentry, @svrnm: Looking forward to your feedback :)

@iguitton iguitton requested a review from a team as a code owner October 11, 2024 09:57
dmathieu
dmathieu reviewed Oct 11, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
content/fr/_index.md Outdated Show resolved Hide resolved
content/fr/_index.md Outdated Show resolved Hide resolved
content/fr/_index.md Outdated Show resolved Hide resolved
content/fr/_index.md Show resolved Hide resolved
@iguitton
Issue 5348
17b33ec 
Took Damien's comment into account
bertysentry
bertysentry reviewed Oct 11, 2024
View reviewed changes
hugo.yaml Outdated Show resolved Hide resolved
bertysentry
bertysentry reviewed Oct 11, 2024
View reviewed changes
.cspell.yml Outdated Show resolved Hide resolved
svrnm
svrnm reviewed Oct 11, 2024
View reviewed changes
hugo.yaml Show resolved Hide resolved
iguitton and others added 3 commits October 14, 2024 08:49
@iguitton @bertysentry
Update hugo.yaml
4194510 
Co-authored-by: Bertrand Martin <[email protected]>
@iguitton
issue 5384: Create homepage for French localization
d3681bc 
* Translated developer_note
* Updated the Dev/Ops translation
* Fixed mispelling in hugo.yaml
* Added required references in .cspell
* Created /.cspell/fr-mots.txt
* Added mountpoints
@iguitton
Merge branch 'main' into feature/issue-5384-create-homepage-for-frenc…
dbf6f82 
…h-localization
@svrnm
Copy link
Member

svrnm commented Oct 14, 2024

Preview is working now: https://deploy-preview-5386--opentelemetry.netlify.app/fr/ 🇫🇷

svrnm
svrnm reviewed Oct 14, 2024
View reviewed changes
content/fr/_index.md Outdated Show resolved Hide resolved
@iguitton @svrnm
Update content/fr/_index.md
94736f4 
Co-authored-by: Severin Neumann <[email protected]>
@svrnm
Copy link
Member

svrnm commented Oct 14, 2024

I am just checking why the words list is not applied and the spell checker is failing. All the other issues can be resolved by running npm run fix:all locally or by a slash fix:all here in a comment

@iguitton
Copy link
Contributor Author

slash fix:all

@svrnm
Copy link
Member

svrnm commented Oct 14, 2024

slash fix:all

I didn't write the / and added a space to not trigger that command by accident, note that if you use that, make sure you pull the changes locally once the run is finished

svrnm
svrnm reviewed Oct 14, 2024
View reviewed changes
content/fr/_index.md Outdated Show resolved Hide resolved
@iguitton
Copy link
Contributor Author

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11323980554

@svrnm
Copy link
Member

svrnm commented Oct 14, 2024

I am just checking why the words list is not applied and the spell checker is failing.

The spell checker is working, but it seems that the dictionary we are using lacks a lot of common french words. Not sure why this is the case, but I suggest for getting this PR finished add all of them to the fr-mots.txt and we take a look into https://github.com/streetsidesoftware/cspell-dicts/tree/main/dictionaries/fr_FR later

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

iguitton and others added 3 commits October 14, 2024 12:09
@iguitton
Merge branch 'main' into feature/issue-5384-create-homepage-for-frenc…
857eea5 
…h-localization
@iguitton
Issue 5384
4b328bb 
Added all the unknown words in mots.txt
@iguitton
Issue 5384
afa896b 
* Translated a menu
@svrnm svrnm mentioned this pull request Oct 14, 2024
Closed
4 tasks
@svrnm svrnm requested review from bertysentry and dmathieu October 14, 2024 12:58
svrnm
svrnm approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but it would be great to have at least one person who is native French speaker provide a review, even if it is not a "green checkbox"

pierrehilbert
pierrehilbert reviewed Oct 14, 2024
View reviewed changes
content/fr/_index.md Outdated Show resolved Hide resolved
dmathieu
dmathieu reviewed Oct 14, 2024
View reviewed changes
content/fr/_index.md Outdated Show resolved Hide resolved
content/fr/_index.md Outdated Show resolved Hide resolved
iguitton and others added 3 commits October 14, 2024 15:37
@iguitton @dmathieu
Update content/fr/_index.md
f497974 
Co-authored-by: Damien Mathieu <[email protected]>
@iguitton @dmathieu
Update content/fr/_index.md
a39b380 
Co-authored-by: Damien Mathieu <[email protected]>
@iguitton
Issue 5384
942e621 
Changed "nombreux" to "nombreuses"
@pierrehilbert
Copy link
Contributor

I don't have permissions to approve this but now this is green flag on my end :-)

@iguitton
Issue 5384
2b70fc7 
Added nombreuses to fr-mots.txt
@svrnm svrnm added this pull request to the merge queue Oct 14, 2024
@svrnm
Copy link
Member

svrnm commented Oct 14, 2024

Merci à tous ! Allons-y! OpenTelemetry en français! 🇫🇷

Merged via the queue into open-telemetry:main with commit d319692 Oct 14, 2024
17 checks passed
@svrnm
Copy link
Member

svrnm commented Oct 14, 2024

https://opentelemetry.io/fr/

@iguitton iguitton deleted the feature/issue-5384-create-homepage-for-french-localization branch October 14, 2024 14:54
This was referenced Dec 19, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrehilbert pierrehilbert pierrehilbert left review comments

@svrnm svrnm svrnm approved these changes

@dmathieu dmathieu dmathieu approved these changes

@bertysentry bertysentry Awaiting requested review from bertysentry

Assignees
No one assigned
Labels
None yet
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iguitton @svrnm @opentelemetrybot @pierrehilbert @dmathieu @bertysentry